Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ventes Bid Adapter: fix web placement support #7715

Merged
merged 12 commits into from
Nov 17, 2021

Conversation

jessoventes
Copy link
Contributor

Type of change

  • Bugfix
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)

Description of change

Fix - Ventes web placement support

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@lgtm-com
Copy link

lgtm-com bot commented Nov 16, 2021

This pull request introduces 3 alerts when merging 9cacac1 into 35bb363 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@jessoventes
Copy link
Contributor Author

Hello @ChrisHuie,
I have made new fix to support web placements for our server, ventesBidAdapter.js code test is passed but, i am not sure on the error showing on the Circleci build. Can you please have a look on it and let me know the changes required? Just to update we are not supporting coppa.
Thanks!!

@ChrisHuie ChrisHuie changed the title Fix - Ventes web placement support Ventes Bid Adapter: fix web placement support Nov 16, 2021
@jessoventes
Copy link
Contributor Author

Thanks @ChrisHuie . Just wanted to check will this changes be merged tomorrow?

@gwhigs gwhigs merged commit 76a5864 into prebid:master Nov 17, 2021
@jessoventes
Copy link
Contributor Author

Is this changes released?

cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants